commaai / commaai/openpilot

race condition when controls allowed times out near an engagement

Open
#27,479 4 comments 0 reactions 1 assignee Claimed by @adeebshihadeh View on GitHub
bug controls
Dominant language
Python
Stars
63.7k
Forks
11.4k
Avg merge
17h 53m
Merged PRs (30d)
171

Description

Basically, get panda's `controlsAllowed` to rise but make it a noEntry to openpilot. Then around 2 seconds later, engage.

For example in a button enable car: press set with seatbelt off, then put seatbelt back on and press set around 2 seconds later.

d4958b8ee5ef5cb3|2023-03-01--09-56-23--1

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.