commaai / commaai/opendbc

Make can_valid consider checksums and counters

Closed
#594 0 comments 0 reactions 0 assignees View on GitHub
bug
Dominant language
Python
Stars
3.4k
Forks
2.3k
Avg merge
2d 8h
Merged PRs (30d)
39

Description

In this segment (`6f63165f17c0e270|2022-03-19--23-09-55--92`), a Genesis had a controls mismatch due to the car sending a message with an invalid checksum so panda stopped allowing messages but we don't check this in the CAN parser.

- [ ] Consider checksums and counters (need flags to ignore checksums in certain cases? eg. legacy HKG)
- [ ] Add checksum for Hyundai

Contributor guide

No contributing guide indexed for this repository

Research direction

Start by locating the CAN parser and reviewing how the cited Genesis segment is handled. Define how checksum and counter validation should work, including any flags needed for legacy HKG cases, and verify that Hyundai checksum support is covered before considering the work done.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
embedded-iot, networking
Issue type
Feature
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.