Honda safety: enable with brake pressed entering standstill race condition
- Dominant language
- Python
- Stars
- 3.4k
- Forks
- 2.3k
- Avg merge
- 3d 2h
- Merged PRs (30d)
- 38
Description
### Describe the car bug
Disabling cruise main causes car to fault.
It appears the disabling cruise main properly triggers ET.USERDISABLE. However ET.USERDISABLE seems to be allowing longcontroller to still command accel, causing safety to block accel messages, causing can bus fault for no messages received by powertrain.
805f87f5e96d128c/00000001--71998fc5a4/2
### Provide a route where the issue occurs
805f87f5e96d128c/00000001--71998fc5a4/2
### openpilot version
nightly-dev c12860e52e5c2bf33bce2937a29fc517a53b9911
### Additional info
_No response_
Contributor guide
No contributing guide indexed for this repository
Research direction
Start by replaying route 805f87f5e96d128c/00000001--71998fc5a4/2 on openpilot nightly-dev c12860e52e5c2bf33bce2937a29fc517a53b9911 and trace ET.USERDISABLE through longcontroller and Honda safety handling. Check when accel messages are blocked after cruise main is disabled and the car enters standstill. Done means disabling cruise main no longer causes a CAN fault from missing powertrain messages.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python
- Domain
- embedded-iot
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Quiet
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100