commaai / commaai/opendbc

CANParser: always parse all messages

Closed
#2,605 1 comment 0 reactions 0 assignees View on GitHub
enhancement
Dominant language
Python
Stars
3.4k
Forks
2.3k
Avg merge
2d 8h
Merged PRs (30d)
39

Description

Fix for problem 1 from https://github.com/commaai/opendbc/pull/2547

---

I think the fix for this is to speed up the parsing such that we can always comfortably parse all messages and signals, then maintain a list of actually read messages to use for the `canValid` flag.

---

This should also let us ship https://github.com/commaai/opendbc/pull/2549.

Contributor guide

No contributing guide indexed for this repository

Research direction

Start by reading problem 1 in PR #2547 and the proposed relationship with PR #2549; the issue does not identify files or tests. Done means CANParser can parse all messages and signals comfortably while canValid is based on messages actually read.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
embedded-iot
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.