commaai / commaai/opendbc

safety: speed mismatches should make rx go invalid

Open
#2,234 1 comment 0 reactions 0 assignees View on GitHub
car safety enhancement
Dominant language
Python
Stars
3.4k
Forks
2.3k
Avg merge
3d 2h
Merged PRs (30d)
38

Description

Instead it just sets controls_allowed to false

note that Tesla compares a signed speed with an unsigned speed currently

Contributor guide

No contributing guide indexed for this repository

Research direction

Start by tracing where speed mismatches are handled and how the receive path marks messages invalid. Compare the current signed-versus-unsigned speed behavior noted for Tesla. Done means a speed mismatch invalidates rx, rather than only setting controls_allowed to false.

Written by the indexing model from the issue text.

Assessment

Domain
embedded-iot
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.