commaai / commaai/opendbc

Hyundai CAN FD safety: abstract duplicate addr logic

Open
#2,108 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
Python
Stars
3.4k
Forks
2.3k
Avg merge
3d 2h
Merged PRs (30d)
38

Description

Why is this not a function? There's a few places where we check the same thing that could be in one function. Same with buses

https://github.com/commaai/opendbc/blob/1a59488c69b5f751af31db17684f90ae3fc067b9/opendbc/safety/safety/safety_hyundai_canfd.h#L162

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.