commaai / commaai/opendbc

Hyundai CAN FD: fix safety tx and rx struct names

Open
#2,106 1 comment 0 reactions 0 assignees View on GitHub
Dominant language
Python
Stars
3.4k
Forks
2.3k
Avg merge
3d 2h
Merged PRs (30d)
38

Description

Can you tell what these two are for? Do they include longitudinal actuation messages or not?

```
static const CanMsg HYUNDAI_CANFD_LFA_STEERING_LONG_TX_MSGS[] = {
...

#define HYUNDAI_CANFD_LFA_STEERING_CAMERA_SCC_TX_MSGS(longitudinal) \
...
```

Hint

First should make it clear it's a radar SCC car. Second should make it clear it also includes longitudinal actuation messages.

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.