Rivian R1S and R1T have different wheelbase and masses
- Dominant language
- Python
- Stars
- 3.4k
- Forks
- 2.3k
- Avg merge
- 2d 8h
- Merged PRs (30d)
- 39
Description
### Describe the bug
Rivians have different wheelbase but [in the code](https://github.com/commaai/opendbc/blob/397fada3c2e65f6cf9c3403cff79498ec4871297/opendbc/car/rivian/values.py#L31), it uses the same wheelbase for both R1S and R1T. The values look like for R1S but the most of the testing was done in R1T (AFAIK). There is one user on discord that says their R1S can't handle some curves (not very sharp). They uploaded [a route](https://connect.comma.ai/e237aa42043c6e14/00000007--d48989ac88/263/455) in the discord.
### Which car does this affect?
Rivian R1S and R1T
### Provide a route where the issue occurs
e237aa42043c6e14/00000007--d48989ac88/263/455
### openpilot version
N/A
### Additional info
_No response_
Contributor guide
No contributing guide indexed for this repository
Research direction
Start in opendbc/car/rivian/values.py at line 31 and inspect how the R1S and R1T vehicle parameters are defined. Compare the wheelbase and mass values for both models with the route linked in the issue; done means the two vehicles have distinct, correct parameters and the relevant handling behavior is covered by validation.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python
- Domain
- embedded-iot
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 52/100