commaai / commaai/opendbc

safety tests: add common test case for bad checksums and counters

Open
#1,768 0 comments 0 reactions 0 assignees View on GitHub
car safety enhancement
Dominant language
Python
Stars
3.4k
Forks
2.3k
Avg merge
3d 2h
Merged PRs (30d)
38

Description

The Honda and VW tests implement this, but it should be added to the base test suite for all safety modes. https://github.com/commaai/panda/blob/1dfee5973bc2884b61e55b7614f2fe90d0e2a1f3/tests/safety/test_honda.py#L117

Contributor guide

No contributing guide indexed for this repository

Research direction

Start with the checksum and counter test in tests/safety/test_honda.py around line 117, then inspect the base safety test suite and the corresponding VW test. Run the safety tests to understand their common structure; done means the case is covered for all safety modes.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
testing-qa
Issue type
Feature
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
48/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.