commaai / commaai/opendbc

API cleanup notes

Open
#1,204 1 comment 1 reaction 0 assignees View on GitHub
cleanup refactor
Dominant language
Python
Stars
3.4k
Forks
2.3k
Avg merge
3d 2h
Merged PRs (30d)
38

Description

Dumping notes here as I work on #1197

* longControl.pid -> longControl.accel?
* remove all the "openpilot", "controlsd", etc.
* carParams.safetyModel should use the int values, needed for interacting with panda https://github.com/commaai/opendbc/blob/cbad7f00669904646e74e8f1b8f66e5ead62b6b9/opendbc/car/panda_runner.py#L26
* abstract out fault handling and more into "ready to control"
* abstract away "pcmCruise"
* move "VCruiseHelper" and relevant state: https://github.com/commaai/openpilot/blob/f59a1bf00344432acad686f4813069e7c0c063b6/selfdrive/controls/lib/drive_helpers.py#L42

Contributor guide

No contributing guide indexed for this repository

Research direction

Start by reviewing issue #1197, which this note says is the active work context. Then inspect the referenced locations in opendbc/car/panda_runner.py and openpilot's selfdrive/controls/lib/drive_helpers.py, along with each listed cleanup item. The work is done only when the scope and implementation of all listed API and control abstractions are resolved.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
api
Issue type
Refactor
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
20/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.