[$300 Bounty] Toyota: cancel cruise without chime
- Dominant language
- Python
- Stars
- 3.4k
- Forks
- 2.3k
- Avg merge
- 3d 2h
- Merged PRs (30d)
- 38
Description
The way openpilot cancels cruise control on most Toyotas has the side effect of a chime from the car and a momentary fault on the dash. When openpilot sends the cancellation message, it also sends a message to play a good chime to mask the fault chime that would play, so start by [removing that](https://github.com/commaai/openpilot/blob/fa62b9d3f9882ec33559ceb7377fa991be1d4fb5/selfdrive/car/toyota/toyotacan.py#L82). Once you remove the good chime, you should hear the fault chime, which we're trying to get rid of.
The Lexus IS uses a [different cancellation message](https://github.com/commaai/openpilot/blob/fa62b9d3f9882ec33559ceb7377fa991be1d4fb5/selfdrive/car/toyota/carcontroller.py#L94) than the rest of the Toyotas, so that's probably a good place to start.
$200 for a merged PR that meets this criteria:
1. no chime sound or even momentary fault display
2. reliable, i.e. always immediately cancels cruise
3. generic across all Toyotas
Feel free to open a PR once steps 1 and 2 are done to lock the bounty pending confirmation of 3.
Contributor guide
No contributing guide indexed for this repository
Research direction
Start in selfdrive/car/toyota/toyotacan.py at line 82 and selfdrive/car/toyota/carcontroller.py at line 94, comparing the Lexus IS cancellation message with the other Toyota paths. Investigate how the cancellation messages affect the chime and momentary fault display. Done means cruise cancels immediately and reliably without a chime or fault display across all Toyotas.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python
- Domain
- embedded-iot
- Issue type
- Bug
- Difficulty
- 5/5
- Estimated time
- Over a week
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 25/100