commaai / commaai/opendbc

GM Camera ACC: cancel camera cruise when OP long

Open
#1,127 1 comment 0 reactions 0 assignees View on GitHub
car enhancement gm
Dominant language
Python
Stars
3.4k
Forks
2.3k
Avg merge
3d 2h
Merged PRs (30d)
38

Description

Camera sends alerts over GMLAN which we can't control, so you'll get messages like "hill too steep" and other strange alerts that don't affect anything that are caused by mismatches between the camera thinking it's engaged (it doesn't check the ECM status :facepalm:) when the ECM actually isn't (like if OP prevents a fault from the brake pressure issue at a stop).

Send a cancel button to the camera if it is enabled with OP long to silence some of these alerts

TODO:
- [ ] Check this doesn't break anything
- [ ] Check it actually works

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.