commaai / commaai/opendbc

GM: Cruise Fault at standstill

Open
#1,125 18 comments 0 reactions 0 assignees View on GitHub
bug car gm
Dominant language
Python
Stars
3.4k
Forks
2.3k
Avg merge
2d 8h
Merged PRs (30d)
39

Description

### Describe the bug

Some cases, where I like to use stock ACC or OpenPilot ACC to hold my brake at a stop light, occasionally would trigger Cruise Faulted red alert.

I am able to replicate this on master, master-ci and other forks as well. Happens both on stock and op ACC.

![image](https://github.com/commaai/openpilot/assets/607941/78d86eb4-f5f4-4647-93d0-4c738962ab41)

### Which car does this affect?

2020 GMC Sierra 1500

### Provide a route where the issue occurs

dc7716b32bf25574|2023-12-22--21-09-03--5

### openpilot version

0.9.6

### Additional info

_No response_

Contributor guide

No contributing guide indexed for this repository

Research direction

Begin with the supplied route dc7716b32bf25574|2023-12-22--21-09-03--5 and the 2020 GMC Sierra 1500 context, comparing stock ACC and openpilot ACC behavior at a standstill. Trace the relevant cruise-fault handling and CAN/DBC data, then verify that the reproduced route no longer produces a false Cruise Faulted alert.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
reverse-engineering
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.