commaai / commaai/opendbc

Honda: check regen paddle

Open
#1,100 14 comments 0 reactions 0 assignees View on GitHub
bug car honda
Dominant language
Python
Stars
3.4k
Forks
2.3k
Avg merge
2d 8h
Merged PRs (30d)
39

Description

### Describe the bug

## TL;DR

Honda Insight's brake regen adjustment paddles cause OP to throw a CruiseDisabled error instead of canceling cruise control.

## More Info

The Honda Insight has adjustable regenerative braking. This is controlled by paddles on the steering wheel. Hitting either paddle when cruise is engaged will disengage cruise.

Disengaging cruise control in this fashion causes OP to trigger a "cruise not engaged" message and sound the alarm, instead of gracefully exiting cruise control via the "Cancel" button. This is governed in the Honda interface, [L332](https://github.com/commaai/openpilot/blob/a2bb41e0ec5fd96763e9a01a7116efda059de6e6/selfdrive/car/honda/interface.py#L332).

It appears that the car sends a generic "Cruise Control disabled" message; there's a lot of junk in Cabana for this trip which isn't mapped to any signals, but one of those could be the issue.

### Desired Outcome

When using the steering wheel paddles to disable cruise control, OP should treat this as a standard disablement instead of an emergency.

### Which car does this affect?

Honda Insight EX 2019

### Provide a route where the issue occurs

8958942b212e8cd9|2023-11-30--08-18-06--10

### openpilot version

On `release3`, latest release.

### Additional info

_No response_

Contributor guide

No contributing guide indexed for this repository

Research direction

Start at selfdrive/car/honda/interface.py around L332 and examine how the Honda Insight's generic cruise-disabled message is handled. Use route 8958942b212e8cd9|2023-11-30--08-18-06--10 and the referenced Cabana data to identify the paddle-related signal. Done means paddle disengagement follows the normal cruise-cancel path without a CruiseDisabled error or alarm.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
embedded-iot, reverse-engineering
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
42/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.