commaai / commaai/flash

Add non-Brave browser message to Not Enough Storage Message

Open
#232 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
JavaScript
Stars
20
Forks
73
PR merge metrics
No merged PRs in 30d

Description

https://github.com/brave/brave-browser/wiki/Deviations-from-Chromium-%28features-we-disable-or-remove%29#:~:text=Have%20StorageManager.estimate%20report%20a%20fixed%20value%20%2311543

Apparently they hardcode 2GB as the reported limit.

https://discord.com/channels/469524606043160576/1436852432503046294/1546299534404231329

funny enough, the [balloon](https://github.com/commaai/flash/pull/231) test passes: https://discord.com/channels/469524606043160576/1436852432503046294/1546302643247255674

Contributor guide

No contributing guide indexed for this repository

Research direction

Trace where the “Not Enough Storage Message” is generated and compare the browser storage behavior described in the linked Brave issue. Define the non-Brave browser wording and verify that the existing balloon test still passes while the new message appears in the intended browser case.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript
Domain
frontend
Issue type
Feature
Difficulty
3/5
Estimated time
1-2 days
Activity status
Active
Clarity
Needs clarification
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.