commaai / commaai/connect

replace duplicate device pairing code

Open
#418 0 comments 0 reactions 0 assignees View on GitHub
cleanup
Dominant language
JavaScript
Stars
134
Forks
95
Avg merge
15h 27m
Merged PRs (30d)
25

Description

The UI elements for the successful pairing of a device is duplicated:
- in `explorer.jsx` (pair tokens in URL only)
- in the `AddDevice` component (pairing user QR scanner/camera)

https://github.com/commaai/connect/blob/master/src/components/Dashboard/AddDevice.jsx
https://github.com/commaai/connect/blob/master/src/components/explorer.jsx#L238

Contributor guide

No contributing guide indexed for this repository

Research direction

Compare src/components/explorer.jsx around line 238 with src/components/Dashboard/AddDevice.jsx to trace the duplicated successful-pairing UI. Identify a shared implementation that supports both URL pair tokens and the QR scanner/camera flow, then verify that both pairing paths still display the expected result without duplicated UI.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript
Domain
frontend
Issue type
Refactor
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.