commaai / commaai/connect

readonly users should be able to request uploads

Open
#203 3 comments 0 reactions 0 assignees View on GitHub
enhancement
Dominant language
JavaScript
Stars
134
Forks
95
Avg merge
15h 27m
Merged PRs (30d)
25

Description

C2/C3 owners who have shared their devices readonly with another user are doing it because they need remote support. Other than very simple things like UDS fingerprint lookups, these remote support needs usually require full logs to be uploaded.

Now that full logs can only be uploaded on-demand, each drive we want to look at needs to be manually uploaded, and today that can only be done by the actual device owner. This means we need new, novice users to constantly take extra actions.

~~From a privacy perspective, there's no difference between the full logs/full videos and the decimated logs/low quality videos, and readonly users can see the full versions once uploaded. The only thing we can't do is trigger the upload action.~~

It was recently pointed out the driver cam might be recorded but not uploaded, and requesting uploads for those as a readonly user would have a nonzero impact to privacy. That's information/video area that isn't already in the qlogs or qcams that a readonly user can already see. IMO it would be fine to restrict readonly users to requesting rlogs for upload, no cameras at all.

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.