colthreepv / colthreepv/angular-media-player

Wrong calculation in seekPercentage() in examples.

Open
#69 1 comment 1 reaction 0 assignees View on GitHub
Dominant language
JavaScript
Stars
228
Forks
69
PR merge metrics
No merged PRs in 30d

Description

$event.target.offsetWidth have different value depends on click place.
![image](https://cloud.githubusercontent.com/assets/1125080/5290686/30069258-7b5a-11e4-9b36-9d2ec73ec8e8.png)

If we click on the area which not was played before everything {green arrow} seekPercentage works good. Because target area is
$event.target = (div.progress) which have static width.

But if click target in played area {red arrow}.
$event.target = (div.progress-bar) which have fluid width, calculation become wrong.

To reproduce bug, just click two times in one place at red arrow (div.progress-bar).

Contributor guide

No contributing guide indexed for this repository

Research direction

Start in the examples area by locating seekPercentage() and inspect how $event.target is selected for div.progress and div.progress-bar. Reproduce the bug by clicking twice in the played area, then verify that repeated clicks at the same position calculate the same seek percentage as clicks in the unplayed area.

Written by the indexing model from the issue text.

Assessment

Tech stack
angularjs, javascript
Domain
frontend
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.