collective / collective/sc.embedder
Refactor embed Consumer Utility error handling to fix YouTube tests
- Dominant language
- JavaScript
- Stars
- 3
- Forks
- 7
- PR merge metrics
- No merged PRs in 30d
Description
After https://github.com/collective/sc.embedder/issues/95, we discovered that the Oembed Consumer Utility error handling needs to be improved, since Youtube returns a html page instead of a well formed json if the video is Unauthorized or Not Found (https://github.com/collective/sc.embedder/blob/c5d1eef09fca938a3bf3deb35d1914236f0b186c/src/sc/embedder/utility.py#L43).
A more detailed explanation about this whole situation can be found in https://github.com/collective/sc.embedder/pull/96#issuecomment-752257370.
Since the embed functionality for Youtube embed is completely broken, these refactoring and the tests will be fixed later.
Contributor guide
No contributing guide indexed for this repository
Assessment
This issue has not been assessed yet.