collective / collective/pas-plugins-identity

Coverage floor is 95; raise it back to 100 as the gap closes

Open
#8 0 comments 0 reactions 1 assignee Claimed by @ericof View on GitHub
Dominant language
Python
Stars
1
Forks
0
Avg merge
39m
Merged PRs (30d)
38

Description

## Where it stands

`fail_under` in `backend/pyproject.toml` is **95**, lowered from 100 so continuous integration has a gate it can pass while the gap is closed. 100% branch coverage is still the standard this package holds itself to, and still the target: an authentication plugin has no line that is fine to leave unexercised.

## The numbers, measured rather than estimated

| suite | tests | coverage | uncovered |
|---|---|---|---|
| full | 2606 | **99.15%** | 124 statements |
| `make test` | 2568 | **97.52%** | 498 statements |

**The 374-statement difference is not untested code.** Those statements are covered by the `docker`-marked tests, which `make test-coverage` does not run — they need containers and an image built from this tree.

## Two separate pieces of work

1. **124 statements genuinely uncovered.** This is the real work, and what raising the floor back to 100 requires.

2. **374 statements covered but unmeasured.** Fixed by measuring the full suite, which needs the coverage job to build the demo image first. The `Backend: Container integration` job already does exactly that, so folding coverage into it is the cheap version. Kept separate for now, deliberately.

A floor set near the container-free number would have written off the 374 as well, which is why it is 95.

## This is a ratchet

Raise it as (1) closes. It is not a setting to be left alone.

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.