collective / collective/collective.dancing

bug: emtpy list has the meaning of subscribed to everything

Open
#13 1 comment 0 reactions 0 assignees View on GitHub
bug
Dominant language
Python
Stars
3
Forks
10
PR merge metrics
No merged PRs in 30d

Description

collector.py:147

```
sdata = subscription.collector_data
name = 'selected_collectors'
if name in sdata and sdata[name] and self not in sdata[name]:
return [], now
```

if sdata[name] is a empty list then then the above code makes the assumption that the subscription is subscribed to everything - this does seem to be rather over-assuming since an empty list is more likely to mean explicitly not subscribed to anything. Suggest changing it to

```
sdata = subscription.collector_data
name = 'selected_collectors'
if name in sdata and self not in sdata[name]:
return [], now
```

Contributor guide

No contributing guide indexed for this repository

Research direction

Start at collector.py:147 and inspect how subscription.collector_data and selected_collectors are interpreted. Change the empty-list behavior so it does not imply subscription to every collector, then verify that an empty selected_collectors list returns no collectors while the field’s absence preserves the existing behavior.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
backend
Issue type
Bug
Difficulty
1/5
Estimated time
Under an hour
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.