colinmarc / colinmarc/impala-ruby

Kerberos hash comments has :provider, but :principal is passed

Open
#22 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
Thrift
Stars
34
Forks
20
PR merge metrics
No merged PRs in 30d

Description

This may be a case where the comments are out-of-date.

In [impala.rb:39](https://github.com/colinmarc/impala-ruby/blob/master/lib/impala.rb#L39) it has :provider as an entry for the :kerberos hash:

```ruby
# - *:provider* (String)
```

However, later on, in [sasl_transport.rb:25](https://github.com/colinmarc/impala-ruby/blob/master/lib/impala/sasl_transport.rb#L25) ,:principal is actually passed instead of :provider:

```ruby
@gsscli = GSSAPI::Simple.new(@options[:host], @options[:principal])
```

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.