coinbase / coinbase/verifying-paymaster

Duplicated fields of `userOp.paymasterPostOpGasLimit` and `paymasterData.postOpGas`

Open
#13 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
Solidity
Stars
8
Forks
8
PR merge metrics
No merged PRs in 30d

Description

In the current `master` branch, it seems that `userOp.paymasterPostOpGasLimit` and `paymasterData.postOpGas` are duplicated, because `userOp.paymasterPostOpGasLimit` and `paymasterData.postOpGas` are both added in the signature hash, and the wallet backend must use the exact suggested value of `paymasterPostOpGasLimit` returned by paymaster through [ERC-7677](https://eips.ethereum.org/EIPS/eip-7677). There's no need to use `paymasterData.postOpGas` and add extra validity checks such as https://github.com/coinbase/verifying-paymaster/blob/6bee4b9161962dd5accbad15999c732b607bc3fa/src/VerifyingPaymaster.sol#L275-L278 anymore.

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.