coinbase / coinbase/temporal-ruby

Temporal testing fails for `:terminate_if_running` reuse policy

Open
#306 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
Ruby
Stars
287
Forks
113
Avg merge
6d 11h
Merged PRs (30d)
1

Description

When enabling testing, the gem runs this check on workflows: https://github.com/coinbase/temporal-ruby/blob/5d12aa30e3f3169c5950c7cfb287bca796ce1a4e/lib/temporal/testing/temporal_override.rb#L141

The problem is that `disallowed_statuses` (at https://github.com/coinbase/temporal-ruby/blob/5d12aa30e3f3169c5950c7cfb287bca796ce1a4e/lib/temporal/testing/temporal_override.rb#L152) doesn't consider the valid `terminate_if_running` reuse policy, thus crashing at `disallowed_statuses.include?(execution.status)` due to it returning `nil`.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.