coinbase / coinbase/temporal-ruby

Deprecation message spam

Open
#143 8 comments 8 reactions 0 assignees View on GitHub
Dominant language
Ruby
Stars
287
Forks
113
Avg merge
6d 11h
Merged PRs (30d)
1

Description

Hey folks, I'm just dipping my toes into temporal and this SDK is a lifesaver, thanks for open sourcing it!

I'm playing with temporal locally and I'm seeing a lot of deprecation message spam when running workflows/activities:

```
temporal-poc-app-1 | [DEPRECATION] This method is now deprecated without a substitution
temporal-poc-app-1 | [DEPRECATION] This method is now deprecated without a substitution
temporal-poc-app-1 | [DEPRECATION] This method is now deprecated without a substitution
temporal-poc-app-1 | [DEPRECATION] This method is now deprecated without a substitution
temporal-poc-app-1 | [DEPRECATION] This method is now deprecated without a substitution
```

This appears to be due to [this line](https://github.com/coinbase/temporal-ruby/blob/e249d63cdbdd898ff410c267e8ce51286db982e4/lib/temporal.rb#L36).

Which is still used in multiple spots in the codebase:
- [here](https://github.com/coinbase/temporal-ruby/blob/master/lib/temporal/concerns/payloads.rb#L55)
- [here](https://github.com/coinbase/temporal-ruby/blob/master/lib/temporal/client.rb#L283)
- [and here](https://github.com/coinbase/temporal-ruby/blob/master/lib/temporal/worker.rb#L12)

Do you have any guidance for removing the deprecated code? I'm happy to attempt a PR, but wanted to check with the maintainers first.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.