coinbase / coinbase/salus

Add pnpm audit support

Open
#445 1 comment 1 reaction 0 assignees View on GitHub
Dominant language
HTML
Stars
31
Forks
3
PR merge metrics
No merged PRs in 30d

Description

It would be great if salus supported pnpm support in addition to npm and yarn. The output of `pnpm audit --json` is identical to NPM, so hopefully this is a simple request :)

One caveat to be aware of is that pnpm places the lockfile at the the root of the repository in a monorepo/workspaces setup. For example:

```
package-a/
package.json
package-b/
package.json
package.json
pnpm-lock.yaml
```

If `package-a` had its own `salus-config.yaml`, and we were running the scanner with `--repo_path=/some/path/to/package-a`, the `should_run` check would need to recursively look upwards for the folder containing `.git` and see if `pnpm-lock.yaml` exists at the same level.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.