coinbase / coinbase/salus

Purpose of `safe_local_report_path`?

Open
#377 2 comments 0 reactions 0 assignees View on GitHub
Dominant language
HTML
Stars
31
Forks
3
PR merge metrics
No merged PRs in 30d

Description

Relevant XKCD:

Hi there, I'm curious about what the `path.include?("/.")` check in [safe_local_report_path](https://github.com/coinbase/salus/blob/cddb4ae427e8a6b5cf3771d7494b8b6fabc0bd07/lib/salus/report.rb#L243-L246) is for. The reason I ask is because I'm currently populating the output into a JSON file located at `REPO_PATH/.salus/salus.json`, which triggers this condition.

Could the pattern be updated to `"/.."`, which is less likely to be valid (I can submit a PR if so)?

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.