coinbase / coinbase/onchainkit

Bug: Add `baseBuilder` property in `MiniAppManifest` type and let it include in `withValidManifest`

Open
#2,512 3 comments 0 reactions 0 assignees View on GitHub
Dominant language
TypeScript
Stars
1k
Forks
520
Avg merge
32m
Merged PRs (30d)
2

Description

### Describe the bug and the steps to reproduce it

When a builder wants to import a mini app, `baseBuilder` property is required in the farcaster.json.
Image

In the Quick start repository example (https://docs.base.org/mini-apps/quickstart/create-new-miniapp), adding `baseBuilder` to `minikit.config.ts` does not reflect the change because it uses `withValidManifest ` in `app/.well-known/farcaster.json/route.ts` and the property gets filtered out, as a result, preventing the builde import the miniapp.

```ts
import { withValidManifest } from "@coinbase/onchainkit/minikit";
import { minikitConfig } from "../../../minikit.config";

export async function GET() {
return Response.json(withValidManifest(minikitConfig)); // "baseBuilder" gets lost
}
```

### What's the expected behavior?

`withValidManifest` should not filter out `baseBuilder`

### What version of the libraries are you using?
@coinbase/onchainkit@1.0.2

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.