coinbase / coinbase/coinbase-advanced-py

Coroutine as websocket callback function

Open
#91 1 comment 0 reactions 0 assignees View on GitHub
Dominant language
Python
Stars
361
Forks
131
PR merge metrics
No merged PRs in 30d

Description

There is no way in the web socket when you initialize it to send a coroutine instead of a regular function as the on_message callback. any async is unable to run as part of that or required some workaround.

the change should take place here in my opinion:
https://github.com/coinbase/coinbase-advanced-py/blob/master/coinbase/websocket/websocket_base.py#L508

Contributor guide

No contributing guide indexed for this repository

Research direction

Start in coinbase/websocket/websocket_base.py around line 508 and trace how on_message callbacks are invoked. Confirm how a coroutine callback should be handled, then verify that an async on_message callback can run without a workaround; the issue does not mention a specific test file.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
networking
Issue type
Feature
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.