cognitedata / cognitedata/python-extractor-utils
The base finish metric is not set on clean exit of extractor
Nobody has claimed this yet.
- Dominant language
- Python
- Stars
- 13
- Forks
- 6
- Avg merge
- 2d 6h
- Merged PRs (30d)
- 11
Description
The below finish metric in BaseMetrics is never set during an extractor run. Requiring manually setting it to populate the metric. Is this intended to be the case?
https://github.com/cognitedata/python-extractor-utils/blob/955ff6a13e13868be577b0e3bd81b5825cf75832/cognite/extractorutils/metrics.py#L123-L125
If not, I can contribute to resolving this.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with cognite/extractorutils/metrics.py at the linked BaseMetrics.finish definition and trace the extractor run lifecycle to determine where clean exit is handled. Check whether existing tests cover finish metrics; done means a clean extractor run populates finish without requiring manual assignment, with behavior confirmed by a regression test.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python
- Domain
- tooling
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100