cognitedata / cognitedata/cognite-sdk-python
ValueErrors too generic too do a proper error handling
Nobody has claimed this yet.
- Dominant language
- Python
- Stars
- 92
- Forks
- 38
- Avg merge
- 2d 9h
- Merged PRs (30d)
- 42
Description
There are a lot of ValueErrors raised in this file (and I suppose also other locations in the cognite api client)
These errors are too generic to do a proper error handling with. If the cognite api client is used in any other part of the API, it is unclear whether these ValueErrors should be transformed to 400, 403, or 500 errors.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
The issue points to cognite/client/_api_client.py around line 688; begin by inventorying the ValueErrors there and in the other API-client locations mentioned. Clarify the intended distinction between client error categories and the acceptance criteria with maintainers before changing them, since the issue does not name specific exceptions or tests.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python
- Domain
- api
- Issue type
- Refactor
- Difficulty
- 5/5
- Estimated time
- Over a week
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 25/100