codrsquad / codrsquad/portable-python
possible incorrectness in libffi include dir assignment, doesn't seem impactful
Nobody has claimed this yet.
- Dominant language
- Python
- Stars
- 86
- Forks
- 13
- PR merge metrics
- No merged PRs in 30d
Description
This looks like an obvious mistake but I don't think it matters because the pkgconfig files are correct and provide the path ultimately:
if self.active_module(LibFFI):
yield f"LIBFFI_INCLUDEDIR={self.deps_lib}"
I'll refrain from opening a PR because I'm not sure... it's possible that this is necessary due to libffi nuances and just looks wrong, but there's no comment or commit message to indicate if thats the case.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Read src/portable_python/cpython.py at line 142 and compare the LIBFFI_INCLUDEDIR assignment with the libffi pkg-config paths mentioned in the issue. Check whether the assignment affects the build despite correct pkg-config files. Done means confirming the behavior and documenting or correcting the discrepancy with a focused test if the repository provides one.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python
- Domain
- build-system
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100