codex-team / codex-team/editor.js

Collect all tools under one namespace in umd.

Open
#695 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
TypeScript
Stars
31.9k
Forks
2.2k
Avg merge
1d 1h
Merged PRs (30d)
1

Description

In webpack configs you not have standard naming convension for library name.
https://github.com/editor-js/image/blob/master/webpack.config.js#L45 here you set `ImageTool`,
https://github.com/editor-js/list/blob/master/webpack.config.js#L39 but here you set `Link`.
Webpack allow create [namespaces](https://github.com/webpack/webpack/tree/master/examples/multi-part-library#webpackconfigjs) for library. I think you must collect all tools under EditorJS namespace.

```js
// webpack.config.js
{
output: {
path: __dirname + '/dist',
publicPath: '/',
filename: 'bundle.js',
library: ['EditorJS', 'List'],
libraryTarget: 'umd'
}
}
```
Because EditorJS it's class you not get conflict of namespace, all tools will be collect as static methods.

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.