codex-team / codex-team/editor.js

Inline toolbar gets recreated on every action used

Open
#2,822 2 comments 3 reactions 0 assignees View on GitHub
bug important
Dominant language
TypeScript
Stars
31.9k
Forks
2.2k
Avg merge
1d 1h
Merged PRs (30d)
1

Description

Might not be a bug, but a feature.

Whenever you click on any of the available actions inside inline toolbar (i.e. make text bold, italic, underlined, etc) the whole inline toolbar gets recreated. It's smooth and invisible it you don't use any transitions or animations on this toolbar. But if you open the inline toolbar with a bit more ✨fashion✨, then you get some flashing every time you use any of the inline tools.

**Steps to reproduce:**
1. Add some transitions to .ce-popover__container (to clearly see the problem)
2. Type some text
3. Open inline toolbar by selecting some parts of the text
4. Use any of the inline tools, for example, make that text bold
5. See the flashing

**Expected behavior:**
1. The whole toolbar doesn't get recreated but instead the state of each button is updated using classes or data attributes?
2. This will allow us to have entry and leave transitions and animations for the inline toolbar

**Video of the bug:**
https://github.com/user-attachments/assets/ff6be587-b52a-45f8-a8bb-ac3399a35221

**OS:** Window 11
**Browser:** Google Chrome 128.0.6613.114
**Editor.js version:** 2.30.5

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.