codex-team / codex-team/editor.js

Inline Toolbar rerenders on each selection change

Open
#1,599 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
TypeScript
Stars
31.9k
Forks
2.2k
Avg merge
1d 1h
Merged PRs (30d)
1

Description

On [selectionchange](https://github.com/codex-team/editor.js/blob/next/src/components/modules/ui.ts#L350) [tryToShow](https://github.com/codex-team/editor.js/blob/next/src/components/modules/toolbar/inline.ts#L149) Inline Toolbar method is called which calls `open` method causes Inline Toolbar re-render. Moreover, it causes shortcuts duplication and other non-efficient operations.

We need to show Inline Toolbar only once selection is end or do not re-render it if selection is changed over the same Block

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.