codex-team / codex-team/editor.js

[Bug] Select-all causes all blocks except the original block to be selected

Open
#1,559 0 comments 1 reaction 0 assignees View on GitHub
bug
Dominant language
TypeScript
Stars
31.9k
Forks
2.2k
Avg merge
1d 1h
Merged PRs (30d)
1

Description

Replication steps:

- Move cursor to a block in a document with many blocks
- Press Cmd-A - the text in the current block is selected
- Press Cmd-A - all blocks are selected
- Press Cmd-A - now all blocks, *except the original block*, are selected

Edit: Here is one possible resolution. It removes the ability to press Cmd-A multiple times to toggle selection, which seems acceptable to me: https://github.com/raykyri/editor.js/commit/7129f8c93c70289c31c8b110622700a5e5a712d9

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.