codex-team / codex-team/editor.js

[Bug] Sanitizer rules of inline tools are applied to paragraph tool even when inline tool is disabled

Open
#1,417 0 comments 1 reaction 0 assignees View on GitHub
bug
Dominant language
TypeScript
Stars
31.9k
Forks
2.2k
Avg merge
1d 1h
Merged PRs (30d)
1

Description

Sanitizer rules of inline tools are applied to paragraph tool even when those inline tools is disabled

Steps to reproduce:
1. Configure paragraph tool to not have inline tool - e.g. `inlineToolbar: ['bold', 'italic']`
2. Paste in some html containing `` tags

Expected behavior:
The anchor tags should be stripped out as the link inline tool is not enabled

Actual behaviour
The anchor tags remain

Device, Browser, OS:
Firefox latest, Mac OS X latest

Editorjs version:
2.19.0

Contributor guide

No contributing guide indexed for this repository

Research direction

Reproduce the issue with the paragraph tool configured as inlineToolbar: ['bold', 'italic'], then paste HTML containing anchor tags in Firefox. Trace how sanitizer rules from inline tools are applied when the link tool is disabled; done means disabled inline tools no longer preserve their tags.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript
Domain
frontend
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.