codestates / codestates/withpuppy

[๐Ÿ“Œ To Do] ์ตœ์šฐ์ฒ  / 2021-12-11

Open
#91 0 comments 0 reactions 1 assignee Claimed by @chltjdrhd777 View on GitHub
Completed
Dominant language
JavaScript
Stars
0
Forks
3
PR merge metrics
No merged PRs in 30d

Description

# โœ”๏ธ ํ•ด์•ผ ํ•  ์ผ ๋ฆฌ์ŠคํŠธ

## 1. ํ”„๋ก ํŠธ

- [x] axios ์—์„œ async์š”์ฒญ์œผ๋กœ ๋น„๋™๊ธฐ ํ•จ์ˆ˜ ์š”์ฒญ์ฒ˜๋ฆฌ ๊ตฌํ˜„
- [x] ์ˆ˜์ •์™„๋ฃŒ ๋ฒ„ํŠผ์„ ๋ˆ„๋ฅด๋ฉด ready ์ƒํƒœ๊ฐ€ ๋˜๊ณ , ์•ˆ์˜ ๋‚ด์šฉ๋ฌผ์„ spinner๋กœ ๊ต์ฒดํ•˜๊ณ , ready์ƒํƒœ์ผ๋•Œ๋Š” ๋ฒ„ํŠผ์„ ๋ˆŒ๋Ÿฌ๋„ ๋ฐ˜์‘์—†๋„๋ก return ์ฒ˜๋ฆฌ
- [x] ์œ ์ € ์ •๋ณด์ˆ˜์ • ๋ˆ„๋ฅด๊ณ  ์ œ์ถœํ•˜๊ธฐ๋ฅผ ํ•˜๋ ค๊ณ  ํ–ˆ์„ ๋•Œ ์ „ํ™”๋ฒˆํ˜ธ์˜ ํ˜•ํƒœ๊ฐ€ (000-000-0000 / ์ •๊ทœ์‹ ํ™œ์šฉ) ์ด ์•„๋‹ˆ๋ผ๋ฉด rejectํ•˜๋ฉด์„œ UIํ‘œ์‹œ ๋ณด์˜€๋‹ค๊ฐ€ ์‚ฌ๋ผ์ง(setTimeout์œผ๋กœ ๋‹ค์‹œ ready์ƒํƒœ๋กœ ์ „ํ™˜, ๋งˆ์ง€๋ง‰์— return ์ฒ˜๋ฆฌ๋กœ ์•„๋ฌด๊ฒƒ๋„ ์ฒ˜๋ฆฌํ•˜์ง€ ์•Š๋„๋ก ๋กœ์ง ๊ตฌํ˜„)
- [x] ์œ ์ € ์ •๋ณด ์ˆ˜์ • ๋ˆ„๋ฅด๊ณ  ์ˆ˜์ •์ด ์™„๋ฃŒ๋˜์—ˆ์„ ๊ฒฝ์šฐ, ๋ฐ›์•„์˜ค๋Š” ์ƒˆ๋กœ์šด ์œ ์ € ์ •๋ณด๋กœ ๋ฆฌ๋•์Šค ์Šคํ† ์–ด ์ƒํƒœ ์—…๋ฐ์ดํŠธ
- [x] ๊ฐ•์•„์ง€ ์ •๋ณด ์ˆ˜์ •์€ ์œ ์ € ์ •๋ณด ์ˆ˜์ •๊ณผ ๋™์ผํ•œ ๋กœ์ง ๊ตฌํ˜„

## 2. ์„œ๋ฒ„

- [x] ์œ ์ € ์ •๋ณด ์ˆ˜์ •๊ด€๋ จ ์š”์ฒญ route ์ œ์ž‘ (patch)
- [x] ์œ ์ € ์ •๋ณด ์ˆ˜์ •๊ด€๋ จ ์š”์ฒญ ์ „์— access token์˜ ์œ ํšจ์„ฑ ๊ฒ€์‚ฌ๋ฅผ ๋ฏธ๋“ค์›จ์–ด๋กœ ์ง‘์–ด๋„ฃ๊ธฐ
- [x] ์œ ์ € ์ •๋ณด ์ˆ˜์ •๊ด€๋ จ ์š”์ฒญ์„ ๋ฐ›์„ ๋•Œ์— body์— ํฌํ•จ๋œ ์œ ์ €์•„์ด๋””๋ฅผ ํ†ตํ•ด ์œ ์ € ์กฐํšŒํ›„ ๋‚ด์šฉ ์—…๋ฐ์ดํŠธ (User.update({์—…๋ฐ์ดํŠธ๋‚ด์šฉ},{where๋‚ด์šฉ})
- [x] ์ˆ˜์ • ์„ฑ๊ณต์‹œ ์‘๋‹ต์œผ๋กœ ๋ณ€๊ฒฝ๋œ ์œ ์ €์ •๋ณด ์ „๋‹ฌ
- [x] ๊ฐ•์•„์ง€ ์ •๋ณด ์ˆ˜์ • ์—ญ์‹œ ์œ ์ €์™€ ๋™์ผํ•œ ๋กœ์ง ๊ตฌํ˜„

## 3. ๊ฐœ์ธ๊ณต๋ถ€

- [x] ๋ชจ๋˜ ์ž๋ฐ”์Šคํฌ๋ฆฝํŠธ 4์žฅ ๋ณต์Šต

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.