codesandbox / codesandbox/codesandbox-client
Embed sandbox does not hide navigation above 1280px width
Open
Nobody has claimed this yet.
Needs Triaging
- Dominant language
- JavaScript
- Stars
- 13.6k
- Forks
- 2.4k
- Avg merge
- 6d 19h
- Merged PRs (30d)
- 2
Description
Trying to embed a sandbox in a wide iframe lead to show the navigation panel even with hidenavigation: 1 set. This happens when setting the width to a size higher than 1280px.
Example that works as expected:
width:1280px
<iframe src="https://codesandbox.io/embed/new?fontsize=14&hidenavigation=1&hidedevtools=1&view=preview" style="width:1280px;height:1000px;border:0;border-radius:4px;overflow:hidden" sandbox="allow-modals allow-forms allow-popups allow-scripts allow-same-origin"></iframe>
Example that does not work as expected. The navigation column gets display.
width:1290px
<iframe src="https://codesandbox.io/embed/new?fontsize=14&hidenavigation=1&hidedevtools=1&view=preview" style="width:1290px;height:1000px;border:0;border-radius:4px;overflow:hidden" sandbox="allow-modals allow-forms allow-popups allow-scripts allow-same-origin"></iframe>
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reproducing the issue with the provided embed URL at widths of 1280px and 1290px, using the hidenavigation parameter. Then trace the embed entry point and the navigation visibility behavior; done means navigation remains hidden above 1280px while the existing 1280px behavior still works.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- javascript
- Domain
- frontend
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 42/100