codesandbox / codesandbox/codesandbox-client
Renaming Folders has many glitches/frustrations
Open
Nobody has claimed this yet.
- Dominant language
- JavaScript
- Stars
- 13.6k
- Forks
- 2.4k
- Avg merge
- 6d 19h
- Merged PRs (30d)
- 2
Description
🐛 bug report
When trying to rename a folder there are multiple issues. Some just frustrating, some breaking.
In escalating severity:
- When you create a folder it automatically resorts by alphabetic (less an issue, but complex structures the folder vanishes)
- When you double click to select a word (to delete, copy, etc) it triggers the default event handler and opens the folder.
- When you right click to use the OS spellcheck it de-selects the input field meaning you can never use spell-check
- When the resort happens, it doesn't correctly store the names. When you attempt to rename a folder after adding one, (which triggers the resort) it show the name value of the folder that was in that position before the new folder was added
To Reproduce
Try to rename Folders
Video:
https://www.loom.com/share/edcdbddcc6e547c0b9f654f6edddcf5a
Suggestions:
- Don't put the "New Folder" form as an in-line folder. Use a "New Folder" modal so when the modal closes and the resort happens it doesn't seem like it vanished, perhaps also scroll to the new folder, and maybe even "select" it
- when in "renaming mode" have the input dispose of the double click handler
- Same as 2, capture the right-click/context to not trigger side-effects in parent components.
- This I have no idea.. Stale state?
Your Environment
Mac OSX 11.6, Chrome
- I have read the Contributing Guidelines for this project.
- [ X] I agree to follow the Code of Conduct that this project
adheres to. - [X ] I have searched the issue tracker for an issue that matches the one I want
to file, without success.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reproducing the folder-renaming flow in the browser, including sorting, double-click selection, right-click spellcheck, and renaming after a new folder is added. No source file, test, or entry point is named in the issue, so locating the folder UI and its state handling is required. Done means the reported interactions work without unintended navigation, selection loss, or stale names.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- javascript, react
- Domain
- frontend
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 28/100