codersforcauses / codersforcauses/p2s-v2

[BUG] Unverified User login

Open
#48 0 comments 0 reactions 0 assignees View on GitHub
API hard problem
Dominant language
Vue
Stars
2
Forks
0
PR merge metrics
No merged PRs in 30d

Description

**Problem**
Unverified users can log in using an empty password

**Where/When**
Api authentication logic

**Desired behavior**
- If the verified field on the user object is false, all logins should be blocked.
- When an unverified user has been created, their password is set to "" which is then salted and hashed. This is potentially unwanted behavior.

**Screenshots**
Logging in with an empty password
![image](https://user-images.githubusercontent.com/38243574/156973534-c05e6b27-25c9-4209-b493-523aafd3ee23.png)

Unverified user created with "" as their password (hashed value)
![Screen Shot 2022-03-07 at 1 30 10 pm](https://user-images.githubusercontent.com/38243574/156973698-44b471e8-19f0-46a9-99a5-42cbdfa6568c.png)

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.