coder / coder/websocket

Improve control on close reason

Open
#454 0 comments 1 reaction 0 assignees View on GitHub
Dominant language
Go
Stars
5.5k
Forks
372
PR merge metrics
No merged PRs in 30d

Description

What's the intended usage pattern of the Reader and Writer context w.r.t. closing the connection from the server side?

It seems like the connection is closed automatically by the reader / writer when the context is cancelled. However, I don't have any way of impacting the status and reason for that close within the reader / writer.

Is the intention that the user of the reader / writer closes the connection with the status and reason they want and let the writer / reader return?

Another option could be that this package would support influencing the close status and reason via an error provided as context cancellation cause.

WDYT?

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.