coder / coder/terraform-provider-envbuilder

feat: If repo contains no devcontainer.json, return fallback image instead of builder image

Open
#114 0 comments 1 reaction 0 assignees View on GitHub
Dominant language
Go
Stars
13
Forks
6
PR merge metrics
No merged PRs in 30d

Description

Currently, the provider does a `runCacheProbe` and if there is any error (either cache miss or missing devcontainer.json), it returns the builder image. For a cache miss this is good and fine, but if the devcontainer file is missing it would be nice to avoid the overhead of running envbuilder when starting a workspace container/pod.

All envbuilder does when there is no devcontainer file is (from what I can see) make a minimal dockerfile that is just `FROM `. But for large or many-layered images this is still slow because kaniko has to unpack all the layers. And this will happen every time because the provider always reports a "cache miss".

I suggest that the provider should instead act differently based on what kind of error it gets from `runCacheProbe`.

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.