coder / coder/jetbrains-coder

wrong error message in LinkHandler.kt verifyDownloadLink()

Open
#551 1 comment 0 reactions 0 assignees View on GitHub
good first issue
Dominant language
Kotlin
Stars
33
Forks
18
Avg merge
2d 13h
Merged PRs (30d)
1

Description

The logic the defines the error message logic is inverted.
If allowlisted is false (= not allowlisted) but https is true it will show the "not using HTTPS" error message
If https is false (= not using https) but allowlisted=true it will show the "not-allowlisted" error message

``` val comment =
if (allowlisted) {
"The download link is from a non-allowlisted URL"
} else if (https) {
"The download link is not using HTTPS"
} else {
"The download link is from a non-allowlisted URL and is not using HTTPS"
}
```

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.