coder / coder/internal

Check dev container (container) properties before attempting to modify CAP_NET_ADMIN

Open
#683 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
No language data
Stars
3
Forks
0
PR merge metrics
No merged PRs in 30d

Description

Right now we try to set CAP_NET_ADMIN on the agent binary within the dev container (similar to our bootstrap scripts). This is to improve network performance, but we could probably skip the attempt if we know the container won't support it and thus not print a warning.

See `agent/agentcontainers/api.go`.

---

This will probably fail unless the container is running as privileged or has the specific CAP_NET_ADMIN privilege set on the container?

_Originally posted by @johnstcn in https://github.com/coder/coder/pull/18245#discussion_r2132512004_

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.