coder / coder/internal

flake: e2e externalAuth.spec.ts

Open
#356 3 comments 0 reactions 0 assignees View on GitHub
flake
Dominant language
No language data
Stars
3
Forks
0
PR merge metrics
No merged PRs in 30d

Description

# Problem

See https://github.com/coder/internal/issues/212 for context.

```
==> Errors
/home/runner/work/coder/coder/site/e2e/tests/externalAuth.spec.ts:15:
13 | import { beforeCoderTest, resetExternalAuthKey } from "../hooks";
14 |
> 15 | test.beforeAll(async ({ baseURL }) => {
| ^
16 | const srv = await createServer(gitAuth.webPort);
17 |
18 | // The GitHub validate endpoint returns the currently authenticated user!
"beforeAll" hook timeout of 30000ms exceeded.
```

It looks like the hardcoded port (50516) can be unavailable for more than 30s.

# Proposed Solution

1) Simply bump the timeout (https://github.com/coder/coder/pull/16528)

2) Refactor the e2e tests to dynamically create a port.

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.