coder / coder/coder

Refactor `templateVersionDynamicParameters` to remove control flag and send websocket errors

Open
#18,478 0 comments 0 reactions 1 assignee Claimed by @Emyrk View on GitHub
Dominant language
Go
Stars
14.5k
Forks
1.5k
Avg merge
1d 20h
Merged PRs (30d)
601

Description

This code currently operates with a control flag `listen`

https://github.com/coder/coder/blob/ae827703d8f75ebc77f07f436ad3200f48fa2ed1/coderd/parameters.go#L71-L112

This requires a `nolint` and should be fixed. Additionally, http errors are not well received by websocket based FE requests. These errors should be translated to the websocket message to be properly rendered on the FE.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.