coder / coder/code-server

[Bug]: PWA Icon Doesn't Display When Using Reverse Proxy

Open
#5,248 30 comments 0 reactions 0 assignees View on GitHub
bug
Dominant language
TypeScript
Stars
79.3k
Forks
6.8k
Avg merge
2d 6h
Merged PRs (30d)
41

Description

### Is there an existing issue for this?

- [X] I have searched the existing issues

### OS/Web Information

- Web Browser: Safari
- Local OS: iPadOS 15.5
- Remote OS: Libreelec (Linux Server Docker)
- Remote Architecture: x86_64
- `code-server --version`: v4.4.0

### Steps to Reproduce

1. Reverse Proxy code-server
2. Open code-server via the proxied subdomain on an iPad using Safari
3. Tap the Share Button
4. Press Add to Home Screen

### Expected

The home screen icon should resemble the favicons in the favicon folder

### Actual

See the home screen icon which is a screenshot of the VS Code workbench (current page view)

### Logs

_No response_

### Screenshot/Video

![image](https://user-images.githubusercontent.com/26024131/172608685-e9797486-bcf6-4697-b18b-081db3135f4f.jpeg)

### Does this issue happen in VS Code?

- [X] I cannot reproduce this in VS Code.

### Are you accessing code-server over HTTPS?

- [X] I am using HTTPS.

### Notes

Tried to add favicon routes using Nginx but that didn't work either.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.