codepath / codepath/android_guides

Proposed ProGuard keep rules are extremely broad (== bad)

Open
#342 1 comment 1 reaction 0 assignees View on GitHub
Dominant language
No language data
Stars
28.3k
Forks
6.2k
PR merge metrics
No merged PRs in 30d

Description

The article mentions "the most basic example of ensuring your library classes are exported" as including

```
-keep public class * {
public protected *;
}
```

... these are very imprecise keep rules which will undermine the effectiveness of ProGuard across the rest of any app that includes this library. Even presenting the rules here as a viable option may be doing harm for library developers and the consumers of those libraries.

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.