codeforpdx / codeforpdx/PASS

[Discovery] - Add loading animation to modals

Open
#637 0 comments 0 reactions 1 assignee View on GitHub

@russfraze is already working on this.

Since May 22, 2024.

  • #654 by @russfraze — open
discovery enhancement
Dominant language
JavaScript
Stars
38
Forks
23
Avg merge
11m
Merged PRs (30d)
4

Description

Note: This issue is marked for discovery. It is open for discussion and not necessarily decided upon.

Describe the Current Behavior/Feature:

When the user uploads a file from the Upload Document modal, there is no indication about the progress. There is a notification upon completion or failure, but nothing until then.

Rationale:

Adding this animation would provide real-time feedback to the user so they know if it's working, and whether the upload even began or not. For small files, this isn't a big problem. But for larger ones it would be good to give more information.

Example of how it currently appears once a file is selected and the Upload button pressed:
CurrentUploadDocumentProcess2

The only visible change is the Upload button becoming greyed out.

Proposed Changes:
  • Add a simple loading animation to modals that (namely the Upload Document modal).
  • Try implementing LoadingAnimation.jsx rather than create a new, separate function or component.
  • Style it based off of the proposed design from the Figma board:
AddUploadingAnimation

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.